Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update remaining e.cash usages w/ New Expensify #4968

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 31, 2021

Details

While investigating Firebase logs for another issue, I noticed that we're still using e.cash when logging for the ErrorBoundary component, so I went through and updated the remaining usages in the codebase.

Tests/QA

None, this just updates readme and comments

@Jag96 Jag96 self-assigned this Aug 31, 2021
@Jag96 Jag96 requested a review from a team as a code owner August 31, 2021 23:49
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team August 31, 2021 23:49
@ctkochan22 ctkochan22 merged commit 0a0eba3 into main Sep 1, 2021
@ctkochan22 ctkochan22 deleted the joe-update-ecash-usages branch September 1, 2021 17:36
@OSBotify
Copy link
Contributor

OSBotify commented Sep 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

🚀 Deployed to staging by @ctkochan22 in version: 1.0.91-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.92-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants